Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve files metadata in lock files #1460

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

sdispater
Copy link
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR is an improvement over #1183.

It removes the hashes metadata in favor of a files metadata which contains the list of files and their hashes for each package.

I removed the package_type property from the original PR since it can be guessed from the file property.

It's important to note that it's backwards compatible with the existing lock files.

@sdispater sdispater added the kind/feature Feature requests/implementations label Oct 11, 2019
@sdispater sdispater added this to the 1.0 milestone Oct 11, 2019
@sdispater sdispater force-pushed the improve-files-metadata-in-lock-file branch from dd8992c to 2c78625 Compare October 11, 2019 14:37
@sdispater sdispater merged commit b1c4c68 into master Oct 11, 2019
@sdispater sdispater deleted the improve-files-metadata-in-lock-file branch October 11, 2019 14:51
michielboekhoff pushed a commit to michielboekhoff/poetry that referenced this pull request Oct 29, 2019
michielboekhoff pushed a commit to michielboekhoff/poetry that referenced this pull request Oct 29, 2019
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant