Fixed path based dev-dependencies break install --no-dev when the d…
#1119
Conversation
…irectory path does not exist.
| @@ -147,7 +148,7 @@ def create(cls, cwd): # type: (Path) -> Poetry | |||
|
|
|||
| package.add_dependency(name, constraint) | |||
|
|
|||
| if "dev-dependencies" in local_config: | |||
| if "dev-dependencies" in local_config and not "--no-dev" in sys.argv: | |||
There was a problem hiding this comment.
Hm this change may affect all commands ( did not test it yet )
There was a problem hiding this comment.
Indeed, this doesn't look like the correct place to manage the behavior of the install command. What the --no-dev option does is it sets Installer.dev_mode attribute and you can probably work off of that.
There was a problem hiding this comment.
Hello,
yes you are right, this is a bad place, its more like patch / workaround. Unfortunately if you look closely into the code, you would find that class Poetry defined in this file is initialised in every single command, even the one which does not to anything effective, therefore it is required to change this control mechanism somehow
JJ.
Yes, its habit, this is not going to be merged, ignore it |
|
Closing since we were told to ignore. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixed path based dev-dependencies break
install --no-devwhen the directory path does not exist.