fix(add): do not pass @latest to parser

[abn]

We should not pass in front-end specific @latest descriptor to the core requirement parser.

Relates-to: #10068

Summary by Sourcery

Strip out the '@latest' descriptor from requirements before parsing to prevent passing front-end specific descriptors to the core parser, and add a test to verify this behavior.

Bug Fixes:

• Fix the issue where the '@latest' descriptor was incorrectly passed to the core requirement parser by stripping it out before parsing.

Tests:

• Add a test to ensure that the '@latest' descriptor is stripped out before parsing and does not affect the package version selection.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses the issue of passing the '@latest' descriptor to the core requirement parser by stripping it from the requirement strings before parsing. A new test was added to ensure this behavior is correctly implemented.

Sequence diagram for requirement parsing without @latest

sequenceDiagram
    participant User
    participant AddCommand
    participant Parser

    User->>AddCommand: Add dependency
    AddCommand->>AddCommand: _parse_requirements()
    Note over AddCommand: Strip @latest descriptor
    AddCommand->>Parser: parse(cleaned_requirement)
    Parser-->>AddCommand: Parsed requirement
    AddCommand-->>User: Dependency added

Loading

Flow diagram for requirement string processing

flowchart LR
    A[Raw Requirement] -->|Input| B[Strip @latest]
    B -->|Regular Expression| C[Clean Requirement]
    C -->|Parse| D[Parsed Requirement]

    style A fill:#f9f,stroke:#333,stroke-width:2px
    style D fill:#9f9,stroke:#333,stroke-width:2px

Loading

File-Level Changes

Change	Details	Files
Added a test to ensure '@latest' is stripped from requirements in the add command.	Added a new test function to check that '@latest' is removed from the requirement string before parsing. Used a mocker spy to verify that the RequirementsParser's parse method is called with the correct arguments.	tests/console/commands/test_add.py
Modified the requirements parsing logic to strip '@latest' from requirement strings.	Updated the _parse_requirements method to use a regular expression to remove '@latest' from each requirement string before parsing.	src/poetry/console/commands/init.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @abn - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}