RunCommand incorrectly sets sys.argv for Poetry scripts

[chdsbd]

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: macOS 10.13
• Poetry version: 0.12.11
• Link of a Gist with the contents of your pyproject.toml file: https://github.com/chdsbd/poetry-repro/blob/master/pyproject.toml

Issue

sys.argv varies when running package through poetry run vs poetry shell

• poetry run cli, sys.argv == ['cli']
• poetry shell && cli, sys.argv == ['/full/path/to/package/.venv/bin/cli']

EDIT: I've looked into this a little bit more and it seems like this RunCommand code is the root of the issue. We are assigning incorrect values to sys.argv for the executable. I believe that sys.argv should be args that, if called, will run the same program as the running program.

poetry shell is going to always work correctly because it doesn't touch Poetry. The virtualenv is added to the path so we're calling directly to the executable in the virtualenv bin.

For the fix, I think we want to lookup the full path to the Poetry script in virtualenv bin and use that executable path as the first arg in sys.argv. I think that should fix this issue and make the behavior of calling scripts through poetry run equal to poetry shell.

[dimaqq]

I think I've hit this issue with tornado dev mode hot reload (i.e. tornado restarts when app source code change is detected).

That is, poetry run this-app starts but later fails to reload.
While poetry shell and then this-app starts and later reloads OK.

When reload is broken, tornado tries to restart the app as /path-to-system/python this-app

[chdsbd]

Yes. I hit this with the Django hot reload server.

[chdsbd]

@sdispater I've looked into this more and updated the issue with more information. I believe there is bug with RunCommand and poetry scripts.

[chdsbd]

I've opened PR #1001 to fix this.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[chdsbd]

This is still an issue. I have a PR open (#1001) that will fix this.

[wagnerluis1982]

A kindly notice to the maintainers, the fix is available, and already applied review commments, at PR #6737

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.