-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export requirements.txt - local dependency file exported as editable #897
Comments
Bumping this issue. We're noticing a similar problem and it's causing problems for our serverless deployments. Pip is complaining whenever we try to install from the |
+1 |
I've come across something similar. My export came with the editable flag for a dependency using a Git url. Had to remove the flag before I could deploy it using Pip in production. Using Poetry 1.0.0b2. |
I think this line here needs to be changed to remove the https://github.com/sdispater/poetry/blob/master/poetry/utils/exporter.py#L84 I see a few other In any case, a quick workaround is to use
|
I'm having the same issue here. |
Thanks for reporting! #1840 should fix it. fin swimmer |
Unless I'm mistaken this still adds the -e tag? I'm calling |
Hello @JulianFerry , can you show an example of your output where you think it's still wrong? fin swimmer |
As a full reproducible example, I did:
then added this to my pyproject.toml:
then:
returns:
|
@JulianFerry the behavior is correct here. Path dependencies are installed in editable mode (by default). So it's also exported in editable mode. fin swimmer |
@finswimmer |
+1 for having the installation method of path dependencies being controllable by a flag. Use case: When build time comes in a Dockerfile, though, a solution to having path dependencies at all is to have them installed (by copy / non-editable) to a venv in a multi-step build, and simply copy the venv from build to final image. From my experimentation this seems to be accomplishable by either |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Issue
poetry export --without-hashes --format=requirements.txt
ouputs local file dependencies as "editable":This is reported as an error when parsed by
pip install
:The correct format should not include the
-e
part (ref. https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format).NOTE:
This is covered in
test_exports.py
https://github.com/sdispater/poetry/blob/develop/tests/utils/test_exporter.py#L353The text was updated successfully, but these errors were encountered: