Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect requirements.txt formatting in poetry export #4575

Closed
alexifm opened this issue Sep 30, 2021 · 3 comments · Fixed by #4733
Closed

Incorrect requirements.txt formatting in poetry export #4575

alexifm opened this issue Sep 30, 2021 · 3 comments · Fixed by #4733
Labels
kind/bug Something isn't working as expected

Comments

@alexifm
Copy link

alexifm commented Sep 30, 2021

The requirements.txt format needs to put a space in front of the semicolon that specifies the package and the pyversion and platform constraints. Right now, without the space, the semicolon will be interpreted as part of a URL. See this issue in packaging:
pypa/packaging#456
@alexifm alexifm added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Sep 30, 2021
@pmav99
Copy link
Contributor

pmav99 commented Sep 30, 2021

@alexifm which poetry version do you use? In poetry 1.2 this will probably need to get fixed in https://github.com/python-poetry/poetry-export-plugin

I will open a ticket there.

@pmav99 pmav99 mentioned this issue Sep 30, 2021
Closed
pmav99 added a commit to pmav99/poetry-export-plugin that referenced this issue Sep 30, 2021
@pmav99
Add space before the semicolon separating the package and the platfor…
342fe43 
…m constraints

Fixes python-poetry#12

Related to:

- python-poetry/poetry#4575
- pypa/packaging#456
@pmav99 pmav99 mentioned this issue Sep 30, 2021
Merged
@alexifm
Copy link
Author

alexifm commented Sep 30, 2021 

─❯ poetry -V
Poetry version 1.1.10

pmav99 added a commit to pmav99/poetry that referenced this issue Oct 2, 2021
@pmav99
Separate the package and the platform constraints in poetry export
2a0cd55 
Fixes python-poetry#4575

Related to:

- pypa/packaging#456
- python-poetry/poetry-plugin-export#12
@pmav99 pmav99 mentioned this issue Oct 2, 2021
Closed
2 tasks
pmav99 added a commit to pmav99/poetry that referenced this issue Nov 11, 2021
@pmav99
Separate the package and the platform constraints in poetry export
300094d 
Fixes python-poetry#4575

Related to:

- pypa/packaging#456
- python-poetry/poetry-plugin-export#12
@pmav99 pmav99 mentioned this issue Nov 11, 2021
Merged
2 tasks
neersighted pushed a commit that referenced this issue Nov 14, 2021
@pmav99 @neersighted
Separate the package and the platform constraints in poetry export
b430c1f 
Fixes #4575

Related to:

- pypa/packaging#456
- python-poetry/poetry-plugin-export#12
neersighted pushed a commit to python-poetry/poetry-plugin-export that referenced this issue Nov 14, 2021
@pmav99 @neersighted
Add space before the semicolon separating the package and the platfor…
d78934d 
…m constraints

Fixes #12

Related to:

- python-poetry/poetry#4575
- pypa/packaging#456
1nF0rmed pushed a commit to 1nF0rmed/poetry that referenced this issue Nov 15, 2021
@pmav99 @1nF0rmed
Separate the package and the platform constraints in poetry export
2af35e7 
Fixes python-poetry#4575

Related to:

- pypa/packaging#456
- python-poetry/poetry-plugin-export#12
edvardm pushed a commit to edvardm/poetry that referenced this issue Nov 24, 2021
@pmav99 @edvardm
Separate the package and the platform constraints in poetry export
0d5bd28 
Fixes python-poetry#4575

Related to:

- pypa/packaging#456
- python-poetry/poetry-plugin-export#12
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
@finswimmer finswimmer mentioned this issue Mar 6, 2022
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
3 participants
@abn @pmav99 @alexifm