Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to dependency specification in the add command documentation #3573

Closed
1 task done
tpow opened this issue Jan 14, 2021 · 2 comments · Fixed by #5656
Closed
1 task done

Add link to dependency specification in the add command documentation #3573

tpow opened this issue Jan 14, 2021 · 2 comments · Fixed by #5656
Labels
area/docs Documentation issues/improvements

Comments

@tpow
Copy link

tpow commented Jan 14, 2021

  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

It took me much too long to figure out how to specify package versions and what the caret meant. I looked at the documentation for the add command, but it only gives a cursory overview of setting constraints. I tried to find it with Google and ended up with PEP-440 which was good, but doesn't explain the caret. For some reason I completely missed the dependency specification in the Poetry documentation sidebar. I guess that is not the terminology I was looking for, even though it makes sense.

Adding a message like the following to the Add command documentation would really help:

See the dependency specification for more information on setting the version constraints for a package.

I think part of what made this difficult is that it is a different mindset than how I normally work with python packages. With pip, I'm typically installing an exact version or latest. With poetry, I'm trying to put constraints in place so it can upgrade reasonably "safely" and get me the version I want now. I therefore needed more details about how to specify the constraints.

@tpow tpow added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Jan 14, 2021
@Secrus Secrus added Good First Issue and removed status/triage This issue needs to be triaged labels May 16, 2022
@Secrus
Copy link
Member

Secrus commented May 16, 2022

PRs on that are welcome.

Secrus added a commit to Secrus/poetry that referenced this issue May 20, 2022
…thon-poetry#3573, python-poetry#2211, python-poetry#521 and PR python-poetry#2414

- Added section about `extras` in `dependency-specification.md` (python-poetry#2414)
- Added note about VCS inclusion and exclusion in `include`/`exclude`
sections of `pyproject.toml` (python-poetry#4800)
- Added link to dependency specification in `add` command documentation
(python-poetry#3573)
- Added more info on default behaviour and cleaned up
`virtualenv.in-project` setting documentation (python-poetry#3709)
- Added missing configuration options to `configuration.md` (python-poetry#2211)
neersighted pushed a commit that referenced this issue May 23, 2022
…5656)

* Changes in docs for Issues #4800, #3709, #3573, #2211, #521 and PR #2414

- Added section about `extras` in `dependency-specification.md` (#2414)
- Added note about VCS inclusion and exclusion in `include`/`exclude`
sections of `pyproject.toml` (#4800)
- Added link to dependency specification in `add` command documentation
(#3573)
- Added more info on default behaviour and cleaned up
`virtualenv.in-project` setting documentation (#3709)
- Added missing configuration options to `configuration.md` (#2211)

Co-authored-by: Arun Babu Neelicattu <[email protected]>
@abn abn mentioned this issue Jun 6, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants