Duplicate entries when running poetry update --dry-run #3097
Comments
MarcoGlauser
added
kind/bug
abn
added
Good First Issue
area/ux
|
@ahlaw most definitey! Feel free to create a draft PR for this if you want to discuss a solution. |
|
Hello everyone! I see this is still open, and the issue is still present in the latest version. |
2 tasks
branchvincent
pushed a commit
that referenced
this issue
Aug 24, 2022
# Pull Request Check List Resolves: #3097 <!-- This is just a reminder about the most common mistakes. Please make sure that you tick all *appropriate* boxes. But please read our [contribution guide](https://python-poetry.org/docs/contributing/) at least once, it will save you unnecessary review cycles! --> - [x] Added **tests** for changed code. I adapted the test in the `tests/console/commands/plugin/test_remove.py` file to reflect the bug fix. - [ ] Updated **documentation** for changed code. <!-- If you have *any* questions to *any* of the points above, just **submit and ask**! This checklist is here to *help* you, not to deter you from contributing! --> Apart from running the ci linting steps and pytest locally for both python 3.6 and 3.8, I also tested the code by running ``` docker run --rm -i --entrypoint bash python:3.8 <<EOF set -e python -m pip install -q git+https://github.com/mmacchia/poetry.git@issue/3097 python -m poetry new foobar pushd foobar sed -i /pytest/d pyproject.toml python -m poetry add --dry-run pycowsay python -m poetry run pip list EOF ``` The corresponding output is: ``` Created package foobar in foobar /foobar / Creating virtualenv foobar-lWDpn5M1-py3.8 in /root/.cache/pypoetry/virtualenvs Using version ^0.0.0.1 for pycowsay Updating dependencies Resolving dependencies... Writing lock file Package operations: 1 install, 0 updates, 0 removals • Installing pycowsay (0.0.0.1) Package Version ---------- ------- pip 21.2.4 setuptools 58.1.0 wheel 0.37.0 ``` As expected, the command `poetry add --dry-run pycowsay` yielded a single output (` • Installing pycowsay (0.0.0.1)`) and did not add the package to the project (see the output of `poetry run pip list`). The change in the PR solves the duplication issue because the creation of the console output when `not self._enabled` is taken care of by the boolean output of the`self._should_write_operation(operation)` function. Please feel free to get in touch if I can help adding more test cases for the `--dry-run` argument or the `_enabled` flag and to add any feedback. I would be happy to improve/clarify the code in this PR. Co-authored-by: Marco Macchia <[email protected]>
This was referenced Aug 23, 2023
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I am on the latest Poetry version.
I have searched the issues of this repo and believe that this is not a duplicate.
If an exception occurs when executing a command, I executed it again in debug mode (
-vvvoption).OS version and name: Ubuntu 20.04
Poetry version: 1.1.1
Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/MarcoGlauser/804cbf48001f7a7d1d94d6da9bc88071
Issue
The command
poetry update --dry-runduplicates the output of packages as seen below.I first noticed it in poetry 1.1.0. I could reproduce it on different machines with the attached gist.
The text was updated successfully, but these errors were encountered: