Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install git: Setup.py Parsing #1761

Closed
duichwer opened this issue Dec 18, 2019 · 2 comments · Fixed by #1764
Closed

Install git: Setup.py Parsing #1761

duichwer opened this issue Dec 18, 2019 · 2 comments · Fixed by #1764
Assignees
Labels
kind/bug Something isn't working as expected

Comments

@duichwer
Copy link

Hello,

I tried to install a git dependency since the master branch include needed fixes for the development.
Then I received the following error:

[RuntimeError]                                                 
Unable to retrieve the package version for /tmp/pypoetry-git-self-attentive-parserXXXXX

Based on this error I found the following issue describing a similar problem: #673

I tried to add setuptools as dev dependency and installed it as suggested.
This doesn't helped me and I still recieved the same error message.

Then I took a deeper look into the setup.py of this project (https://github.com/nikitakit/self-attentive-parser/blob/master/setup.py#L23)

There I have seen that setup( was called as setuptools.setup( instead of the most common way to import the setup command directly.

After changing this to setup on my fork everything worked fine.

  • [x ] I have searched the issues of this repo and believe that this is not a duplicate.
  • [x ] I have searched the documentation and believe that my question is not covered.

Issue

Now my question:

Is this an issue with ast parsing and can this be solved in poetry itself or should I ask the project owner to change its setup.py?

@finswimmer finswimmer added the kind/bug Something isn't working as expected label Dec 18, 2019
@finswimmer finswimmer self-assigned this Dec 18, 2019
@finswimmer
Copy link
Member

In my opinion poetry should be able to parse setuptools.setup().

Fix is on the way: #1764

Thanks a lot for reporting!

sdispater pushed a commit that referenced this issue Dec 20, 2019
…1761) (#1764)

* fix (setup_reader): in `setup.py` the `setup()` method can also be called by `setuptools.setup()`

* fix (setup_reader): make black happy

* fix (setup_reader): skip test for python <3.4
shenek pushed a commit to shenek/poetry that referenced this issue Dec 31, 2019
…ython-poetry#1761) (python-poetry#1764)

* fix (setup_reader): in `setup.py` the `setup()` method can also be called by `setuptools.setup()`

* fix (setup_reader): make black happy

* fix (setup_reader): skip test for python <3.4
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants