Apply CR suggestions

python-poetry · Aug 15, 2023 · d3e308a · d3e308a
1 parent 514bba1
commit d3e308a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/poetry/utils/dependency_specification.py b/src/poetry/utils/dependency_specification.py
@@ -29,6 +29,8 @@
 DependencySpec = Dict[str, Union[str, bool, Dict[str, Union[str, bool]], List[str]]]
 BaseSpec = TypeVar("BaseSpec", DependencySpec, InlineTable)
 
+GIT_URL_SCHEMES = {"git+http", "git+https", "git+ssh"}
+
 
 def dependency_to_specification(
     dependency: Dependency, specification: BaseSpec
@@ -143,7 +145,7 @@ def _parse_url(self, requirement: str) -> DependencySpec | None:
         if not (url_parsed.scheme and url_parsed.netloc):
             return None
 
-        if url_parsed.scheme in ["git+https", "git+ssh"]:
+        if url_parsed.scheme in GIT_URL_SCHEMES:
             return self._parse_git_url(requirement)
 
         if url_parsed.scheme in ["http", "https"]:

diff --git a/tests/utils/test_dependency_specification.py b/tests/utils/test_dependency_specification.py
@@ -24,7 +24,7 @@
     [
         (
             "git+https://github.com/demo/demo.git",
-            {"git": "https://github.com/demo/demo.git", "name": "demo"},
+            ({"git": "https://github.com/demo/demo.git", "name": "demo"},),
         ),
         (
             "git+https://github.com/demo/demo.git",