Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --index-url handling for Poetry 1.8 - second try #270

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

radoering
Copy link
Member

  • if PyPI is disabled the highest prio source get --index-url, others get --extra-index-url
  • if PyPI is enabled we just do not use --index-url, all other source get --extra-index-url
  • put --index-url before --extra-index-url to work around a pip bug

Resolves: #269
Resolves: #149

Copy link

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix #269 for me, thanks!

@radoering radoering requested a review from a team March 18, 2024 19:08
- if PyPI is disabled the highest prio source get `--index-url`, others get `--extra-index-url`
- if PyPI is enabled we just do not use `--index-url`, all other source get `--extra-index-url`
- put `--index-url` before `--extra-index-url` to work around a pip bug
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.0% Duplication on New Code

See analysis details on SonarCloud

@radoering radoering merged commit 07f8981 into python-poetry:main Mar 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants