Alter rev-parse syntax to support msys git #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
This PR replaces an existing one as the relevant code had moved
Details
On windows,
msys
andcygwin
versions ofgit
need braces to be escaped when they are invoked via subprocess. (This appears to be an unfortunate side effect of the machinery that converts windows paths to posix-like paths for the executable, and is usually hidden when executing from an msys based shell).If they are not escaped, then
rev^{commit]
becomes a meaninglessrev^commit
to anmsys
git
, resulting in an error.In contrast, we do not want to escape the braces if passing
rev^{commit}
to any other form ofgit
. We can avoid having to decide whether escaping is needed by using the alternative notation^0
.As noted in the
rev-parse
documentationPull Request Check List
Resolves: python-poetry/poetry#2667
Replaces: python-poetry/poetry#2668