Rename Builder to BaseBuilder

[Secrus]

A small change of class name. While working on #679 It was confusing to have poetry.core.masonry.builders.builder and poetry.core.masonry.builder have the same name for 2 different classes.

[bswck]

Thumbs up on that one, I got confused too.

[Secrus]

Damn, the downstream...

[radoering]

Probably requires a deprecation like this https://github.com/python-poetry/poetry/blob/1.3/src/poetry/repositories/pool.py

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[dimbleby]

another option - because BaseBuilder is such an ugly name! - would be simply to deprecate and remove the poetry.core.masonry.builder altogether

if I am right it is used only by the poetry build command. and it is so trivial that the code could reasonably just live in poetry proper all along: there's little value in poetry-core exposing a class for this.

[radoering]

BaseBuilder is such an ugly name

full ack

would be simply to deprecate and remove the poetry.core.masonry.builder altogether

I like that idea because even if we rename the class there are still the modules poetry.core.masonry.builders.builder and poetry.core.masonry.builder, which is confusing enough.