Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom subpackage names in built wheels #672

Merged
merged 9 commits into from
Dec 18, 2023

Conversation

bigstones
Copy link
Contributor

@bigstones bigstones commented Dec 10, 2023

Resolves: python-poetry#

  • Added tests for changed code.
  • Updated documentation for changed code.

python-poetry/poetry#6258

@bigstones bigstones changed the title [WIP] Custom subpackage name in poetry (poetry issue #6258) Custom subpackage name in poetry (poetry issue #6258) Dec 14, 2023
src/poetry/core/masonry/builders/builder.py Show resolved Hide resolved
src/poetry/core/masonry/builders/builder.py Outdated Show resolved Hide resolved
src/poetry/core/masonry/builders/builder.py Outdated Show resolved Hide resolved
@radoering
Copy link
Member

My other two points in #672 (comment) seem to have been overlooked. I hope you don't mind I just implemented them myself. Please take a look and let me know if the changes make sense to you.

@bigstones
Copy link
Contributor Author

My other two points in #672 (comment) seem to have been overlooked. I hope you don't mind I just implemented them myself. Please take a look and let me know if the changes make sense to you.

Looks Good To Me!
I thought I had checked the code, but I guess I forgot. Thank you for letting me know!

Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@radoering radoering changed the title Custom subpackage name in poetry (poetry issue #6258) Allow custom subpackage names in built wheels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants