Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editable installs with extension modules #633

Merged
merged 3 commits into from
Sep 1, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enh: Build extension modules inplace during editable install.
matthewwardrop authored and robbotorigami committed Aug 31, 2023

Unverified

This user has not yet uploaded their public signing key.
commit d9e0b49fa5b481581222d289886d570b731f41c3
9 changes: 9 additions & 0 deletions src/poetry/core/masonry/builders/wheel.py
Original file line number Diff line number Diff line change
@@ -221,6 +221,15 @@ def _copy_file_scripts(self, wheel: zipfile.ZipFile) -> None:
)

def _run_build_command(self, setup: Path) -> None:
if self._editable:
subprocess.check_call(
[
self.executable.as_posix(),
str(setup),
"build_ext",
"--inplace",
]
)
subprocess.check_call(
[
self.executable.as_posix(),