performance: fix a performance regression introduced in #402 #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a perfomance regression introduced in #402 by applying
cached_property
to certain propertiescached_property
is available since Python 3.8. There is a package namedbackports.cached-property
, which makes the decorator available in Python 3.7. However, I don't want to add a new vendored dependency since we will drop Python 3.7 support anyway in the near future. We could introduce a restricted dependency onbackports.cached-property
like in poetry or just accept the performance regression for Python 3.7. I have chosen the latter but do not have strong feelings about it.In the following table you can see the
cumtime
of relevant calls (in seconds) from profiling different variants for a sample project