Allow non-existent path dependencies - reloaded #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2022
Merged
Secrus
previously requested changes
Nov 13, 2022
radoering
force-pushed
the
non-existing-path-deps
branch
from
c0e4927 to
79a5d67
Compare
radoering
force-pushed
the
non-existing-path-deps
branch
from
79a5d67 to
aed056b
Compare
radoering
force-pushed
the
non-existing-path-deps
branch
from
aed056b to
805f9d5
Compare
…ency and DirectoryDependency
* print warning instead of raising an error in __init__ (allows `poetry lock --no-update` with missing locked path dependency that has been removed from pyproject.toml) * introduce explicit `validate` method Co-authored-by: Adrian Garcia Badaracco <[email protected]>
radoering
force-pushed
the
non-existing-path-deps
branch
from
805f9d5 to
5a2dd36
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
neersighted
approved these changes
Jan 22, 2023
|
Awesome glad to see this in! |
Merged
|
Hi, is this feature supposed to allow the usage of poetry install without having the actual path dependencies in the filesystem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#668
Resolves: python-poetry/poetry#6828
Supersedes: #210, #507
Requires: python-poetry/poetry#6844 (to preserve comprehensible output in case of error)
Note: Commits should not be squashed.