Fix parsing of git urls with egg before subdirectory #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
force-pushed
the
fix-vcs-git-regex-order
branch
from
98b45de
to
8fc2c9f
Compare
radoering
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Jan 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with parsing git based dependencies. A VCS git dependency may optionally specify tag, egg, and subdirectory attributes. Due to the ordering of regex matching, some of these attributes would be silently ignored. For example,
git+ssh://[email protected]:sdispater/project/my_repo.git@commit#egg=package&subdirectory=project_dirwould properly extract tag ascommitbut subdirectory would beNone. The unit tests already includes these edge case URLs, however, egg name and subdirectory were not being checked. Unit test has been updated to verify subdirectory matches.