normalize extras per PEP685 #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
force-pushed
the
canonicalize-extras
branch
from
aefd98e
to
9f58ecf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
for more information, see https://pre-commit.ci
radoering
approved these changes
Oct 3, 2022
|
@dimbleby Please don't delete your branch until we don't depend on it in poetry anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://peps.python.org/pep-0685/#specification says both that all comparisons should be done with normalized extra names, and that normalized extra names should be written to metadata.
Simplest and surest approach seems to be just to deal with normalized names everywhere.
Fixes python-poetry/poetry#6321.
will cause CI failures in the downstream tests because poetry now records normalized extra names in lockfiles. I think that's correct and will follow up with a poetry MR to fix the unit tests against this.
However this presents some poetry / poetry-core challenges re merge order and version numbering. As in other MRs, I'd advocate for allowing such things and being comfortable going 2.0 here - though even then the cross-repository pipelines want some disentangling.