Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashes #466

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Hashes #466

merged 3 commits into from
Sep 6, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Sep 6, 2022

Fixes python-poetry/poetry#6423 and presumably also python-poetry/poetry-plugin-export#112

I also tidied up a couple of things that I encountered on the way

  • implementation of union and multi marker hashes, which I intended to copy, was surprisingly bogus
  • equality for the multiconstraint was more complex than it needs to be / disturbingly different from the unionconstraint

Accumulating bits for every marker in a multi or union marker is not
sensible, xor rather than or was surely intended
Now essentially the same implementation as on the union constraint
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency add bug: unhashable type: UnionConstraint
2 participants