Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setter for version on ProjectPackage #447

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

bcavagnolo
Copy link
Contributor

@bcavagnolo bcavagnolo commented Aug 24, 2022

This enables support for dynamically setting the package version
(e.g., from a plugin)

Resolves: python-poetry/poetry#6223

  • Added tests for changed code.
  • Updated documentation for changed code.

This enables support for dynamically setting the package version
(e.g., from a plugin)

Resolves: python-poetry/poetry#5493
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@radoering
Copy link
Member

I just added a test that the hash does not change and removed the todo. Iirc, we've added type ignore in such cases before.

@radoering radoering merged commit e19dd6e into python-poetry:main Aug 26, 2022
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
This enables support for dynamically setting the package version
(e.g., from a plugin)

Co-authored-by: Randy Döring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bring back set_version (or similar) to restore ability to dynamically set package version in plugins
2 participants