Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions: preserve any local label when bumping #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abn
Copy link
Member

@abn abn commented Jun 12, 2022

Split out of #379

@abn abn requested a review from a team June 12, 2022 14:46
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dimbleby
Copy link
Contributor

What is this fixing?

I don't think it's obvious what the "right" behaviour is, or even that there is a single right behaviour

  • eg users of poetry version might - or might not - want this updated behaviour
  • there are internal places that call next_minor() and next_major() as part of version comparison, does this change help or hurt them?

@radoering
Copy link
Member

Further, according to PEP 440 local version identifiers are not permitted in inclusive and exclusive ordered comparisons. Thus, the tested constraints are invalid according to PEP 440. If this behavior is required for some reason, we should at least add a comment explaining why it's required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants