-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more mypy
optional error codes and bump mypy
to 0.960
#376
Enable more mypy
optional error codes and bump mypy
to 0.960
#376
Conversation
It looks like PyPy 3.7 has troubles installing typed-ast. It seems to only fail on this pull request because we are updating dependencies here, which invalidates the cache. Will try to bump |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I was wondering why tests on PyPy were not failing in the past, and it looks like I wrongly assumed that we used to use PyPy 3.7 when updating the CI workflow in #364. Looking at an old CI workflow from a PR that also invalidated the cache, we can clearly see that PyPy 3.8 was used when using
Since "Required" checks will need to be updated to require |
Added tests for changed code.Not applicableUpdated documentation for changed code.Not applicableSimilarly to python-poetry/poetry#5665, enable truthy-bool and redudant-expr.
Also update
mypy
to0.960
.Note: I also needed to update the tests CI workflow to use PyPy 3.8 instead of PyPy 3.7, which is what we used to have in the past. See comments for the details.