Remove obsolete code-quality CI workflow#363
Merged
neersighted merged 1 commit intopython-poetry:mainfrom May 23, 2022
Merged
Conversation
neersighted
previously approved these changes
May 23, 2022
Member
|
Removed Linting from required checks. |
Member
|
Will need a rebase because of your other changes, @mkniewallner |
The workflow only runs `pre-commit`, which is already handled by pre-commit CI, so this should not be required anymore.
mkniewallner
force-pushed
the
remove-obsolete-code-quality-workflow
branch
from
b0902c2 to
c5d455c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
Thanks, branch has been rebased. |
neersighted
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for changed code.Not applicableUpdated documentation for changed code.Not applicablecode-qualityworkflow only runspre-commit, which is already handled by pre-commit CI, so it should not be required anymore.For instance on #362, we can see those 2 workflows are doing the same thing:
Note that if this gets merged, the settings of the repository would need to be updated to remove
Lintingfrom the required checks.