Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug/crash when source dir is outside project dir #356

Closed
wants to merge 14 commits into from
Closed

Fix bug/crash when source dir is outside project dir #356

wants to merge 14 commits into from

Commits on May 17, 2022

  1. Update builder.py 

    replace usage of `pathlib.Path.relative_to` with `os.path.relpath`, as per python-poetry/poetry#5621
    @alextremblay
    alextremblay committed May 17, 2022
    Configuration menu
    Copy the full SHA
    dd3d795 View commit details
    Browse the repository at this point in the history

  2. add complete test for src_outside_root

    @alextremblay
    alextremblay committed May 17, 2022
    Configuration menu
    Copy the full SHA
    fa426b7 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed May 17, 2022
    Configuration menu
    Copy the full SHA
    96dc0ce View commit details
    Browse the repository at this point in the history

  4. restructure fixture to not depend on another unrelated fixture

    @alextremblay
    alextremblay committed May 17, 2022
    Configuration menu
    Copy the full SHA
    2eba713 View commit details
    Browse the repository at this point in the history

  5. update test to reflect correct outcome for both sdists and wheels

    @alextremblay
    alextremblay committed May 17, 2022
    Configuration menu
    Copy the full SHA
    39f5efa View commit details
    Browse the repository at this point in the history

  6. update builder.py to pass all tests

    @alextremblay
    alextremblay committed May 17, 2022
    Configuration menu
    Copy the full SHA
    f6b09b0 View commit details
    Browse the repository at this point in the history

  7. merge shenanigans

    @alextremblay
    alextremblay committed May 17, 2022
    Configuration menu
    Copy the full SHA
    d94f568 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. extend source_outside_root test to more closely match realworld condi… 

    …tions
    @alextremblay
    alextremblay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0d3d632 View commit details
    Browse the repository at this point in the history

  2. refactor src_outside_root test to parse setup.py ast and analyze it, … 

    …rather that text matching
    @alextremblay
    alextremblay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    65130f7 View commit details
    Browse the repository at this point in the history

  3. refactor sdistbuilder code and related classes to pass all tests

    @alextremblay
    alextremblay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    37663e0 View commit details
    Browse the repository at this point in the history

  4. apply code formatting & suggestions from code linting tools

    @alextremblay
    alextremblay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    62318b4 View commit details
    Browse the repository at this point in the history

  5. add test conditions to src_outside_root test necessary for a produced… 

    … sdist to be buildable/installable
    @alextremblay
    alextremblay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    c7e1784 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed May 19, 2022
    Configuration menu
    Copy the full SHA
    95ed9a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Merge branch 'main' into fix-issue-5621

    @Secrus
    Secrus authored Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a5a55c0 View commit details
    Browse the repository at this point in the history