Fix special case of get_python_constraint_from_marker() and SingleMarker.only() #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
abn
reviewed
Mar 20, 2022
abn
approved these changes
Mar 22, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the util function
get_python_constraint_from_marker()by fixingSingleMarker.only().Given a marker not containing
python_versionorpython_full_version(e.g.'sys_platform == "linux"'), any python version should be allowed. Thus,get_python_constraint_from_marker()should return"*". Analogously,only("python_version")on aSingleMarker'sys_platform == "linux"'should returnAnyMarker()instead ofEmptyMarker()because ifpython_versionis not mentioned, any version is fine.If the last point seems counterintuitive, keep in mind that
""(empty string) does not representEmptyMarkerbutAnyMarker.Rationale: This fix enables further improvements to reduce the number of overrides in poetry's dependency resolution.