merging python_version and python_full_version markers #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#
recognise that
python_version
andpython_full_version
markers say much the same thing and often can be mergedAs an example of the difference this makes, the
poetry export
testcase that I have added in python-poetry/poetry#5156 sees the following diff when using this fix:The last click marker is not quite perfect, in ideal world we'd recognise that
python_version < "4.0"
was the same aspython_full_version < "4.0.0"
and then merge things - but it's a substantial improvement.