Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort package name in extras to make it reproducible #280

Merged
merged 1 commit into from
Feb 4, 2022
Merged

sort package name in extras to make it reproducible #280

merged 1 commit into from
Feb 4, 2022

Conversation

ali5h
Copy link
Contributor

@ali5h ali5h commented Feb 3, 2022 •
edited
Loading

finswimmer
finswimmer requested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution 👍

Can you please add some tests that cover the changes?

@ali5h
Copy link
Contributor Author

ali5h commented Feb 3, 2022

added

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
3.8% 3.8% Duplication

@ali5h ali5h requested a review from finswimmer February 3, 2022 22:11
finswimmer
finswimmer approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Looks good to me 🚀

@finswimmer finswimmer merged commit 0113a5a into python-poetry:master Feb 4, 2022
@ali5h ali5h deleted the poetry-issue-5125 branch February 4, 2022 06:14
@finswimmer finswimmer mentioned this pull request Feb 9, 2022
Merged
@radoering radoering mentioned this pull request Mar 20, 2022
Closed
2 tasks
DavidVujic pushed a commit to DavidVujic/poetry-core that referenced this pull request Mar 26, 2022
@ali5h @DavidVujic
sort package name in extras to make it reproducible (python-poetry#280)
daa4078 
this fixes python-poetry/poetry#5125
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
@ali5h @bostonrwalker
sort package name in extras to make it reproducible (python-poetry#280)
41fd0b8 
this fixes python-poetry/poetry#5125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package.extras is not reproducible
2 participants
@ali5h @finswimmer