Skip to content

changed code to use default branch if none is specified. #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Armaxxx
Copy link

@Armaxxx Armaxxx commented Dec 7, 2020

Resolves: python-poetry/poetry#3366

  • Added tests for changed code.
  • Updated documentation for changed code.

@sinoroc

This comment has been minimized.

@Armaxxx
Copy link
Author

Armaxxx commented Dec 7, 2020

So, the tests are failing because they expect "master" to be the default branch, however by removing the branch from the url the default "main" branch will be pulled, however it is named.

@finswimmer
Copy link
Member

Hello @Armaxxx,

I just took a quick look at this. I think at least this method

def base_pep_508_name(self): # type: () -> str
must be adopted, to not add a branch if there is no one defined.

fin swimmer

@Armaxxx
Copy link
Author

Armaxxx commented Dec 22, 2020

You're right, I completely missed it, adapted.

@kasteph
Copy link
Member

kasteph commented Mar 28, 2021

Closing in favor of #143. Thank you @Armaxxx.

@kasteph kasteph closed this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git install doesn't recognize new main default branch
4 participants