Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sdist deterministic by setting gzip mtime to 0 #105

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

achow101
Copy link
Contributor

@achow101 achow101 commented Oct 24, 2020

A GZip file contains a timestamp with it's last modification time. This timestamp by default is the current time which will make poetry build produce non-deterministic sdist archives. To make sdist archives deterministic, this timestamp must be set to a fixed time. So this PR sets that time to 0.

Reopening of python-poetry/poetry#870

  • Added tests for changed code.
  • (N/A)] Updated documentation for changed code.

@sdispater sdispater merged commit 8e425a5 into python-poetry:master Jan 29, 2021
@sdispater sdispater mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants