Typing part 1

.flake8

@@ -7,6 +7,9 @@ inline-quotes = double
 enable-extensions = TC, TC1
 type-checking-exempt-modules = typing, typing-extensions
 eradicate-whitelist-extend = ^-.*;
+extend-ignore =
+    # E203: Whitespace before ':'
+    E203
 per-file-ignores =
     __init__.py:F401
 exclude =

crashtest/frame.py

@@ -68,7 +68,9 @@ def file_content(self) -> str:
     def __hash__(self) -> int:
         return hash(self._filename) ^ hash(self._function) ^ hash(self._lineno)
 
-    def __eq__(self, other: Frame) -> bool:
+    def __eq__(self, other: object) -> bool:
+        if not isinstance(other, Frame):
+            raise NotImplementedError
         return (
             self._filename == other.filename
             and self._function == other.function

crashtest/frame_collection.py

@@ -1,13 +1,15 @@
 from __future__ import annotations
 
 from typing import TYPE_CHECKING
+from typing import Any
 
 
 if TYPE_CHECKING:
+
     from crashtest.frame import Frame
 
 
-class FrameCollection(list):
+class FrameCollection(list[Any]):
     def __init__(self, frames: list[Frame] | None = None, count: int = 0) -> None:
         if frames is None:
             frames = []

tests/helpers.py

@@ -1,22 +1,22 @@
 from __future__ import annotations
 
 
-def simple_exception():
+def simple_exception() -> None:
     raise ValueError("Simple Exception")
 
 
-def nested_exception():
+def nested_exception() -> None:
     try:
         simple_exception()
     except ValueError:
         raise RuntimeError("Nested Exception")
 
 
-def recursive_exception():
-    def inner():
+def recursive_exception() -> None:
+    def inner() -> None:
         outer()
 
-    def outer():
+    def outer() -> None:
         inner()
 
     inner()

tests/solution_providers/test_solution_provider_repository.py

@@ -42,19 +42,19 @@ def documentation_links(self) -> list[str]:
         return ["https://foo.bar"]
 
 
-def test_it_has_no_provider_by_default():
+def test_it_has_no_provider_by_default() -> None:
     repository = SolutionProviderRepository()
 
     assert len(repository._solution_providers) == 0
 
 
-def test_providers_can_be_passed_to_constructor():
+def test_providers_can_be_passed_to_constructor() -> None:
     repository = SolutionProviderRepository()
 
     assert len(repository._solution_providers) == 0
 
 
-def test_it_can_find_solutions():
+def test_it_can_find_solutions() -> None:
     repository = SolutionProviderRepository()
 
     repository.register_solution_provider(ExceptionSolutionProvider)

tests/test_frame.py

@@ -7,7 +7,7 @@
 from tests.helpers import simple_exception
 
 
-def test_frame():
+def test_frame() -> None:
     try:
         simple_exception()
     except ValueError as e:
@@ -38,7 +38,7 @@ def test_frame():
     assert hash(other_frame) != hash(frame)
 
 
-def test_frame_with_no_context_should_return_empty_line():
+def test_frame_with_no_context_should_return_empty_line() -> None:
     frame = Frame(inspect.FrameInfo(None, "filename.py", 123, "function", None, 3))
 
     assert frame.line == ""

tests/test_inspector.py

@@ -6,7 +6,7 @@
 from tests.helpers import simple_exception
 
 
-def test_inspector_with_simple_exception():
+def test_inspector_with_simple_exception() -> None:
     try:
         simple_exception()
     except ValueError as e:
@@ -20,7 +20,7 @@ def test_inspector_with_simple_exception():
         assert len(inspector.frames) > 0
 
 
-def test_inspector_with_nested_exception():
+def test_inspector_with_nested_exception() -> None:
     try:
         nested_exception()
     except RuntimeError as e:
@@ -35,7 +35,7 @@ def test_inspector_with_nested_exception():
         assert len(inspector.frames.compact()) == 1
 
 
-def test_inspector_with_recursive_exception():
+def test_inspector_with_recursive_exception() -> None:
     try:
         recursive_exception()
     except RuntimeError as e: