-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve performance of find_similar_names #173
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Seems you have experienced python-poetry/poetry#5970. Update to poetry 1.1.14, clear your cache ( |
thanks this worked |
Not sure whats up with the Python3.11 failures, but I don't think they are caused by the change. |
restarting the CI today solved the build issues, so they were unrelated. |
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxbachmann would you mind writing a simple test for that? I see there are no tests for _utils
module at the moment and this could be a good start.
Sure I can add a test |
on most platforms this improves the performance by 30-40x by using a highly optimized C extension. On unsupported platforms falls back to a pure Python implementation, which still improves performance by 2x.
I added a simple test for |
on most platforms this improves the performance by 30-40x by using a highly optimized C extension.
On unsupported platforms falls back to a pure Python implementation, which still improves performance by 2x.
I am not really familiar with poetry. I used:
However this removed files for a lot of dependencies, which seems wrong. What is the correct process to replace a dependency?