Skip to content
This repository was archived by the owner on Oct 8, 2024. It is now read-only.

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Feb 21, 2022

We can refactor build and build-latest into a single resuable workflow and pass inputs for their differences.

Docs:

Not terribly happy with the wheels.yml + wheels-reusable.yml names, suggestions welcome!


Also put slower macOS first in the matrix, might speed things up a bit:

-        os: [ "ubuntu-20.04", "macos-latest" ]
+        os: [ "macos-latest", "ubuntu-20.04" ]

And while GHA gives 20 concurrent jobs, I just spotted the limit for macOS is 5:

https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits

So another reason to get those queued up sooner.

@radarhere
Copy link
Member

My only idea is to refer to what is different between the two calls, the commit, but I'm not sure that wheels-commit.yml sounds any better. commit-workflow.yml maybe?

@hugovk
Copy link
Member Author

hugovk commented Feb 22, 2022

Decided on wheels-build.yml for the reusable one, as that does the actual wheel building.

And kept wheels.yml for the main one which is managing the whole wheel stuff.

@radarhere radarhere merged commit 4b74b53 into python-pillow:main Feb 22, 2022
@hugovk hugovk deleted the reusable-workflow branch February 22, 2022 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants