Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Sep 18, 2020

For python-pillow/Pillow#4900.

This has these rules:

  • approved by more than one person
  • has automerge label
  • Travis CI has passed

Note that you cannot approve your own PR. And the rules for GHA is a little different than Travis, so let's with the simpler repo.

Docs for reference: https://doc.mergify.io/actions.html#actions

To test

When the CI is still running (or if it finished already, restart a job or the whole thing), approve and add the automerge label.

It should merge once the CI finishes.

@hugovk
Copy link
Member Author

hugovk commented Sep 18, 2020

Actually, I removed this push rule, because the push happened on my fork, and only the PR one is visible here:

      - status-success=continuous-integration/travis-ci/push

@hugovk
Copy link
Member Author

hugovk commented Sep 19, 2020

@radarhere Please could you test this? Thank you!

@radarhere radarhere added the automerge Automatically merge PRs that are ready label Sep 20, 2020
@radarhere
Copy link
Member

Did you mean like that, by approving and labelling? I guess it doesn't apply until it is actually merged.

@radarhere
Copy link
Member

If you want a PR to test it on, I can offer you #85

@hugovk
Copy link
Member Author

hugovk commented Sep 20, 2020

Did you mean like that, by approving and labelling? I guess it doesn't apply until it is actually merged.

Yes. Could be, will merge and test with #85. Thanks!

@hugovk hugovk merged commit db8fa1d into python-pillow:master Sep 20, 2020
@hugovk hugovk deleted the add-mergify-config branch September 20, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge PRs that are ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants