Do not install Pyroma in MinGW, to use only system packages#8562
Merged
hugovk merged 2 commits intopython-pillow:mainfrom Nov 22, 2024
Merged
Do not install Pyroma in MinGW, to use only system packages#8562hugovk merged 2 commits intopython-pillow:mainfrom
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MinGW has started failing in main - https://github.com/python-pillow/Pillow/actions/runs/11950775623/job/33312968743#step:4:233
pyroma is the only library that we are using that doesn't exist as a MinGW package, and since it's not used by Pillow, but is rather a tool to check Pillow only in our test suite, I think the best solution is to just not install it - using system packages would be closest to what the standard user would do.
Also, https://www.msys2.org/docs/python/ now states
so the changes from #7131 and #7224 can be removed.