Skip to content

Conversation

@wiredfool
Copy link
Member

This is the second half of #732, and a companion of #754

This doesn't work with coveralls. There is some sort of error that needs to be fixed somewhere in the coveralls package.

Coverage does work, with the nose-cov plugin.

@wiredfool wiredfool mentioned this pull request Jun 30, 2014
@hugovk
Copy link
Member

hugovk commented Jul 1, 2014

This doesn't work with coveralls. There is some sort of error that needs to be fixed somewhere in the coveralls package.

This should be reported to the package we're using, coveralls-python:
https://github.com/coagulant/coveralls-python/

I just spotted there's a second coveralls package, python-coveralls. Perhaps this'll give better results:
https://github.com/z4r/python-coveralls

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to remove pyroma from Travis CI? It'd be good to keep it to make sure #743 passes on Travis to avoid regressions of #740.

@wiredfool
Copy link
Member Author

I've tried the other coveralls package, it fails in other interesting ways. I'm going to isolate what's going on with a test case before reporting. I think it's this issue: TheKevJames/coveralls-python#43 but I'm not sure.

Pyroma was an oversight from the manual split after the merge.

aclark4life added a commit that referenced this pull request Jul 1, 2014
@aclark4life aclark4life merged commit febfe2f into python-pillow:master Jul 1, 2014
@wiredfool wiredfool deleted the multithread-testing-travis branch September 23, 2014 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants