Skip to content

Flake8 on morphology changes #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aclark4life merged 3 commits into from
Jun 24, 2014
Merged

Flake8 on morphology changes #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd97d30
flake8 on morphology changes
hugovk Jun 24, 2014
540477b
Update a docstring [CI skip]
hugovk Jun 24, 2014
494bffd
Make test runnable on its own
hugovk Jun 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 68 additions & 60 deletions PIL/ImageMorph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@
from PIL import _imagingmorph
import re

LUT_SIZE = 1<<9
LUT_SIZE = 1 << 9


class LutBuilder:
"""A class for building MorphLut's from a descriptive language
"""A class for building a MorphLut from a descriptive language

The input patterns is a list of a strings sequences like these:

Expand All @@ -20,8 +22,8 @@ class LutBuilder:
111)->1

(whitespaces including linebreaks are ignored). The option 4
descibes a series of symmetry operations (in this case a
4-rotation), the pattern is decribed by:
describes a series of symmetry operations (in this case a
4-rotation), the pattern is described by:

. or X - Ignore
1 - Pixel is on
Expand All @@ -42,29 +44,29 @@ class LutBuilder:

lb = LutBuilder(patterns = ["4:(... .1. 111)->1"])
lut = lb.build_lut()

"""
def __init__(self,patterns = None,op_name=None):
def __init__(self, patterns=None, op_name=None):
if patterns is not None:
self.patterns = patterns
else:
self.patterns = []
self.lut = None
if op_name is not None:
known_patterns = {
'corner' : ['1:(... ... ...)->0',
'4:(00. 01. ...)->1'],
'dilation4' : ['4:(... .0. .1.)->1'],
'dilation8' : ['4:(... .0. .1.)->1',
'4:(... .0. ..1)->1'],
'erosion4' : ['4:(... .1. .0.)->0'],
'erosion8' : ['4:(... .1. .0.)->0',
'4:(... .1. ..0)->0'],
'edge' : ['1:(... ... ...)->0',
'4:(.0. .1. ...)->1',
'4:(01. .1. ...)->1']
'corner': ['1:(... ... ...)->0',
'4:(00. 01. ...)->1'],
'dilation4': ['4:(... .0. .1.)->1'],
'dilation8': ['4:(... .0. .1.)->1',
'4:(... .0. ..1)->1'],
'erosion4': ['4:(... .1. .0.)->0'],
'erosion8': ['4:(... .1. .0.)->0',
'4:(... .1. ..0)->0'],
'edge': ['1:(... ... ...)->0',
'4:(.0. .1. ...)->1',
'4:(01. .1. ...)->1']
}
if not op_name in known_patterns:
if op_name not in known_patterns:
raise Exception('Unknown pattern '+op_name+'!')

self.patterns = known_patterns[op_name]
Expand All @@ -75,21 +77,21 @@ def add_patterns(self, patterns):
def build_default_lut(self):
symbols = [0, 1]
m = 1 << 4 # pos of current pixel
self.lut = bytearray([symbols[(i & m)>0] for i in range(LUT_SIZE)])
self.lut = bytearray([symbols[(i & m) > 0] for i in range(LUT_SIZE)])

def get_lut(self):
return self.lut

def _string_permute(self, pattern, permutation):
"""string_permute takes a pattern and a permutation and returns the
string permuted accordinging to the permutation list.
string permuted according to the permutation list.
"""
assert(len(permutation)==9)
assert(len(permutation) == 9)
return ''.join([pattern[p] for p in permutation])

def _pattern_permute(self, basic_pattern, options, basic_result):
"""pattern_permute takes a basic pattern and its result and clones
the mattern according to the modifications described in the $options
the pattern according to the modifications described in the $options
parameter. It returns a list of all cloned patterns."""
patterns = [(basic_pattern, basic_result)]

Expand All @@ -98,29 +100,28 @@ def _pattern_permute(self, basic_pattern, options, basic_result):
res = patterns[-1][1]
for i in range(4):
patterns.append(
(self._string_permute(patterns[-1][0],
[6,3,0,
7,4,1,
8,5,2]), res))
(self._string_permute(patterns[-1][0], [6, 3, 0,
7, 4, 1,
8, 5, 2]), res))
# mirror
if 'M' in options:
n = len(patterns)
for pattern,res in patterns[0:n]:
for pattern, res in patterns[0:n]:
patterns.append(
(self._string_permute(pattern, [2,1,0,
5,4,3,
8,7,6]), res))
(self._string_permute(pattern, [2, 1, 0,
5, 4, 3,
8, 7, 6]), res))

# negate
if 'N' in options:
n = len(patterns)
for pattern,res in patterns[0:n]:
for pattern, res in patterns[0:n]:
# Swap 0 and 1
pattern = (pattern
.replace('0','Z')
.replace('1','0')
.replace('Z','1'))
res = '%d'%(1-int(res))
.replace('0', 'Z')
.replace('1', '0')
.replace('Z', '1'))
res = '%d' % (1-int(res))
patterns.append((pattern, res))

return patterns
Expand All @@ -135,15 +136,16 @@ def build_lut(self):

# Parse and create symmetries of the patterns strings
for p in self.patterns:
m = re.search(r'(\w*):?\s*\((.+?)\)\s*->\s*(\d)', p.replace('\n',''))
m = re.search(
r'(\w*):?\s*\((.+?)\)\s*->\s*(\d)', p.replace('\n', ''))
if not m:
raise Exception('Syntax error in pattern "'+p+'"')
options = m.group(1)
pattern = m.group(2)
result = int(m.group(3))

# Get rid of spaces
pattern= pattern.replace(' ','').replace('\n','')
pattern = pattern.replace(' ', '').replace('\n', '')

patterns += self._pattern_permute(pattern, options, result)

Expand All @@ -154,7 +156,7 @@ def build_lut(self):

# compile the patterns into regular expressions for speed
for i in range(len(patterns)):
p = patterns[i][0].replace('.','X').replace('X','[01]')
p = patterns[i][0].replace('.', 'X').replace('X', '[01]')
p = re.compile(p)
patterns[i] = (p, patterns[i][1])

Expand All @@ -166,25 +168,26 @@ def build_lut(self):
bitpattern = bin(i)[2:]
bitpattern = ('0'*(9-len(bitpattern)) + bitpattern)[::-1]

for p,r in patterns:
for p, r in patterns:
if p.match(bitpattern):
self.lut[i] = [0, 1][r]

return self.lut



class MorphOp:
"""A class for binary morphological operators"""

def __init__(self,
lut=None,
op_name = None,
patterns = None):
op_name=None,
patterns=None):
"""Create a binary morphological operator"""
self.lut = lut
if op_name is not None:
self.lut = LutBuilder(op_name = op_name).build_lut()
self.lut = LutBuilder(op_name=op_name).build_lut()
elif patterns is not None:
self.lut = LutBuilder(patterns = patterns).build_lut()
self.lut = LutBuilder(patterns=patterns).build_lut()

def apply(self, image):
"""Run a single morphological operation on an image
Expand All @@ -193,44 +196,49 @@ def apply(self, image):
morphed image"""
if self.lut is None:
raise Exception('No operator loaded')

outimage = Image.new(image.mode, image.size, None)
count = _imagingmorph.apply(bytes(self.lut), image.im.id, outimage.im.id)
count = _imagingmorph.apply(
bytes(self.lut), image.im.id, outimage.im.id)
return count, outimage

def match(self, image):
"""Get a list of coordinates matching the morphological operation on an image
"""Get a list of coordinates matching the morphological operation on
an image.

Returns a list of tuples of (x,y) coordinates of all matching pixels."""
Returns a list of tuples of (x,y) coordinates
of all matching pixels."""
if self.lut is None:
raise Exception('No operator loaded')
return _imagingmorph.match(bytes(self.lut), image.im.id)

return _imagingmorph.match(bytes(self.lut), image.im.id)

def get_on_pixels(self, image):
"""Get a list of all turned on pixels in a binary image
Returns a list of tuples of (x,y) coordinates of all matching pixels."""

return _imagingmorph.get_on_pixels(image.im.id)

Returns a list of tuples of (x,y) coordinates
of all matching pixels."""

return _imagingmorph.get_on_pixels(image.im.id)

def load_lut(self, filename):
"""Load an operator from an mrl file"""
with open(filename,'rb') as f:
with open(filename, 'rb') as f:
self.lut = bytearray(f.read())
if len(self.lut)!= 8192:

if len(self.lut) != 8192:
self.lut = None
raise Exception('Wrong size operator file!')

def save_lut(self, filename):
"""Load an operator save mrl file"""
"""Save an operator to an mrl file"""
if self.lut is None:
raise Exception('No operator loaded')
with open(filename,'wb') as f:
with open(filename, 'wb') as f:
f.write(self.lut)

def set_lut(self, lut):
"""Set the lut from an external source"""
self.lut = lut

# End of file
Loading