Skip to content

Conversation

@wiredfool
Copy link
Member

Applied patch: matplotlib/matplotlib@a91559b to fix issue #1902
Changes proposed in this pull request:

  • Use PyLong_AsVoidPtr instead of converting a pyint to a py_ssizet, which misses the top half of the address space on 32 bit machines.

@radarhere radarhere changed the title Fix for issue #1902 Applied patch: https://github.com/matplotlib/matplotlib/commit/a9155… Fix for issue #1902 Applied patch: matplotlib/matplotlib/commit/a9155… Jan 20, 2017
@wiredfool wiredfool added Bug Any unexpected behavior, until confirmed feature. Needs Tests labels Jan 22, 2017
@wiredfool
Copy link
Member Author

wiredfool commented Jan 24, 2017

Tests: I can't find a way to trigger this in a 32 bit docker image on a 64 bit machine -- it requires a 32 bit vm at the very least, and it's only getting triggered on Debian, not Ubuntu in my testing.

This fix does work on the 32 bit Debian vm.

Waiting on #2368

@wiredfool
Copy link
Member Author

Pypy 5.6 is segfaulting in _imagingtk.c:_tkinit:

    /* This will bomb if interp is invalid... */
    TkImaging_Init(interp);

It's consistent back to 2.5.0, which is well before the Tk reorg.

@wiredfool wiredfool force-pushed the issue_1902 branch 2 times, most recently from 8d3c2fe to a69c377 Compare January 26, 2017 13:31
@wiredfool wiredfool merged commit 2d06d85 into python-pillow:master Jan 26, 2017
@wiredfool wiredfool deleted the issue_1902 branch October 2, 2017 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Any unexpected behavior, until confirmed feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant