Skip to content

Conversation

@radarhere
Copy link
Member

Removing different segments of code that have been deprecated long enough.

Currently under discussion in #1087.

PIL/ImageDraw.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it's been warned for deprecation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been marked as deprecated in the docs since 1.1.5. I figured it was a sufficient length of time for even a docs warning to be effective. I'll restore the function and add a deprecation warning.

@wiredfool
Copy link
Member

Seems like a reasonable batch of items to be removed. 2 things:

  • I think it would be clearer to the people we're breaking if we replace the deprecated methods with a specific error pointing to a solution, rather than just removing them and having them get an attribute error. We're breaking other people's code here, we should be as nice as possible about it.
  • We should really test this against django. If we break django, we're going to have a bad month.

@wiredfool wiredfool added this to the 3.0.0 milestone Sep 10, 2015
@radarhere
Copy link
Member Author

Okay, I've restored some of the methods, raising an Exception now instead.

I've looked through Django 1.8.4, and it only uses PIL/Pillow at a very high level. None of these changes should affect it.

@wiredfool wiredfool mentioned this pull request Sep 20, 2015
wiredfool added a commit that referenced this pull request Sep 29, 2015
@wiredfool wiredfool merged commit 89ccf66 into python-pillow:master Sep 29, 2015
@radarhere radarhere deleted the deprecated branch September 29, 2015 20:53
hugovk added a commit to hugovk/Pillow that referenced this pull request Jul 14, 2018
The skipping originally applied to ImageFileIO (python-pillow#375), and ImageFileIO was later removed (python-pillow#1343) but this line was missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants