Switch test requirement to pytest-flake8. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 53 53
Lines 1105 1105
=======================================
Hits 1090 1090
Misses 15 15Continue to review full report at Codecov.
|
Flake8 runs both pyflakes and codestyle. Pep8 was renamed to and supported as codestyle.
|
Reference to name change: PyCQA/pycodestyle#466 |
|
Not sure why PyPy is having trouble... |
|
I downgraded pytest pytest-cov but it didn't help. Really strange. |
|
I saw the change in the spec-validator also caused a slow down. The only shared differences are flake8 and pycodestyle. Pytest with coverage + xdist used to cause problems in PyPy due to deadlock but that's been fixed for a while and xdist isn't used here... |
bjmc
pushed a commit
to bjmc/openapi-core
that referenced
this pull request
Jun 12, 2019
Switch test requirement to pytest-flake8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flake8 runs both pyflakes and pycodestyle. Pep8 is deprecated and renamed to pycodestyle.