Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Don't try to disable flake8, document relevant limitation #47

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

projectgus
Copy link
Contributor

@projectgus projectgus commented Oct 13, 2023

Removes flake8 from the list of This plugin will disable [...] by default. This doesn't change the existing behaviour at all:

The flake8 plugin is disabled by default in pylsp. If it's been enabled in the pylsp configuration then it's not actually possible for another plugin like this one to disable it.

The other four plugins disabled by python-lsp-ruff (pycodestyle, pyflakes, mccabe, pyls_isort) are enabled by default so the ruff plugin is able to disable these plugins, provided they're not explicitly enabled in the configuration.

Closes #46

Thanks for maintaining python-lsp-ruff, it's a very handy plugin! 😁

flake8 plugin is disabled by default. If it's been enabled in the pylsp
configuration then it's not possible for another plugin to disable it.

The other four plugins (pycodestyle, pyflakes, mccabe, pyls_isort) are all
enabled by default so the ruff plugin can disable them, provided they're not
explicitly enabled in the configuration.

Closes python-lsp#46
@Shane-XB-Qian
Copy link
Contributor

i am a little confused the title, i remember this 'ruff' plugin was (aim to) going to be the only linter for pylsp,
but now kept the flake8 default be enabled there? if yes, was there some additional configure to disable it?
or some con/pro if leave the 'enable' there? and this seems a bit un-imcompatible (and break game?) if yes.

@jhossbach
Copy link
Member

@Shane-XB-Qian Linting with flake8 is disabled by default. The idea behind removing it from the list of disabled plugins was that it would otherwise awake the idea of it always being disabled, regardless of the user configuration.

Effectively this changes nothing since flake8 is disabled by default unless explicitly enabled by the user.

See #46 for more details

@projectgus
Copy link
Contributor Author

I've edited the description of the PR, as it was a bit terse. Hope that's clearer, @Shane-XB-Qian.

@Shane-XB-Qian
Copy link
Contributor

ok, just wish keep this/its 'aim', make the result be stable and simple/clear.

@Shane-XB-Qian
Copy link
Contributor

Shane-XB-Qian commented Oct 14, 2023

except this linter/diag cfg, the left things (to be refined) of pylsp as i knew maybe were:
hover-doc and auto-import, (maybe init/ws configure too), seems they are doing it now.
// but just the latter one was on 'rope' still, wish someday 'ruff' can offer that....... 😄

@jhossbach jhossbach merged commit 2373aed into python-lsp:main Oct 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-disabling flake8 doesn't seem possible
3 participants