Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add class IntelHexWord for word address #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benfre
Copy link

@benfre benfre commented Jun 28, 2019

for issue: #32

@bialix
Copy link
Member

bialix commented Sep 27, 2019

Sorry for not working on your pull request. I'm looking for a new maintainer for Python IntelHex project. I hope someone will help.

@bialix
Copy link
Member

bialix commented Jul 9, 2020

I understand your intents, but it seems such format is not follow IntelHex-8 standard. Do you have any links or pdf document with hex word format explanations?
Anyway, I don't like the fact you changed the most time-critical function (decode_record). I think it's better to copy decode_record method entirely into new class and make modifications there. Also the IntelHex project is relying on unit tests. We need some unit tests for your class with some simple example of such word file.
Please, rework your class, add unit tests and write some text for manual.

Sorry for not reviewing your patch a year ago. If you don't need it anymore - please say so.

@benfre
Copy link
Author

benfre commented Jul 11, 2020

word address mode is described in the last note

I will try to work on fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants