Skip to content

GitHub Actions: Modernize versions of GitHub Actions and Python #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

GitHub Actions: Modernize versions of GitHub Actions and Python #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v5
with:
submodules: recursive
- uses: actions/setup-python@v1
- uses: actions/setup-python@v6
with:
python-version: 3.8
python-version: 3.x
- name: Run lint
run: |
python -m pip install tox
Expand All @@ -22,17 +22,17 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14", "3.14t"]
steps:
- name: Set git to use LF on Windows
if: runner.os == 'Windows'
run: |
git config --global core.autocrlf false
git config --global core.eol lf
- uses: actions/checkout@v2
- uses: actions/checkout@v5
with:
submodules: recursive
- uses: actions/setup-python@v4
- uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
Expand All @@ -44,16 +44,16 @@ jobs:
package-sdist:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v5
with:
submodules: recursive
- uses: actions/setup-python@v1
- uses: actions/setup-python@v6
with:
python-version: 3.x
- name: Build source package
run: python setup.py sdist
- name: Upload source package
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: sdist
path: dist/
Expand All @@ -71,11 +71,12 @@ jobs:
os: windows-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v5
with:
submodules: recursive
- uses: actions/setup-python@v2

- uses: actions/setup-python@v6
with:
python-version: 3.x
- name: Install cibuildwheel
run: python -m pip install cibuildwheel
# - name: Install Visual C++ for Python 2.7
Expand All @@ -91,16 +92,16 @@ jobs:
if: runner.os == 'Windows'
run: python -m cibuildwheel --output-dir wheelhouse
env:
CIBW_BUILD: cp37-${{ matrix.name }}* pp*-${{ matrix.name }}*
CIBW_BUILD: cp310-${{ matrix.name }}* pp*-${{ matrix.name }}*

- name: Build wheels for Linux and macOS
if: runner.os != 'Windows'
run: python -m cibuildwheel --output-dir wheelhouse
env:
CIBW_BUILD: cp37-${{ matrix.name }}* pp*-${{ matrix.name }}*
CIBW_BUILD: cp310-${{ matrix.name }}* pp*-${{ matrix.name }}*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, can we do this separately?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the message to users is that it is a good idea to build on an insecure platform (security flaws are carefully documented but not fixed for two plus years) that continues to demonstrate that Python is s-l-o-w?!?

I will revert to double legacy Py3.7 but please note my protest.

CIBW_ARCHS_LINUX: auto aarch64
CIBW_BEFORE_BUILD_LINUX: yum install -y libffi-devel
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: wheels-${{ matrix.name }}
path: ./wheelhouse/*.whl
Expand All @@ -109,20 +110,20 @@ jobs:
runs-on: ubuntu-latest
needs: [lint, test, package-sdist, package-wheel]
steps:
- uses: actions/checkout@v2
- uses: actions/download-artifact@v1
- uses: actions/checkout@v5
- uses: actions/download-artifact@v5
with:
name: sdist
path: dist/
- uses: actions/download-artifact@v1
- uses: actions/download-artifact@v5
with:
name: wheels-win
path: dist/
- uses: actions/download-artifact@v1
- uses: actions/download-artifact@v5
with:
name: wheels-macos
path: dist/
- uses: actions/download-artifact@v1
- uses: actions/download-artifact@v5
with:
name: wheels-manylinux
path: dist/
Expand Down
Loading