Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duck paths being returned incorrectly if a query parameter is present. #82

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Fix duck paths being returned incorrectly if a query parameter is present. #82

merged 1 commit into from
Jul 7, 2024

Conversation

lavirlifiliol
Copy link
Contributor

Doing string manipulation breaks with queries in url, this PR instead uses the URL API of fastAPI.

fixes #81

@lavirlifiliol
fix: create path correctly
3ff33b1 
Doing string manipulation breaks with queries in url.
vivekashok1221
vivekashok1221 approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested locally but code looks good to me.

@ChrisLovering ChrisLovering merged commit e3a38ef into main Jul 7, 2024
4 checks passed
@ChrisLovering ChrisLovering deleted the lakmatiol/fix/duck-path branch July 7, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekashok1221 vivekashok1221 vivekashok1221 approved these changes

@ChrisLovering ChrisLovering Awaiting requested review from ChrisLovering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: /duck endpoint does not create correct path in the file response field.
3 participants
@lavirlifiliol @vivekashok1221 @ChrisLovering