Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ab08nz function to support complex state-space systems #96

Merged
merged 10 commits into from
Apr 12, 2020

Conversation

lytex
Copy link
Contributor

@lytex lytex commented Apr 1, 2020

add ab08nz function to support regular pencil for complex state-space systems

@bnavigator
Copy link
Collaborator

Please add one or more unit tests here as discussed in python-control/python-control#376

@lytex
Copy link
Contributor Author

lytex commented Apr 1, 2020

I've written a simple test for both ab08nd and ab08nz.

ab08nd works fine but ab08nz SEGFAULTs

@bnavigator
Copy link
Collaborator

bnavigator commented Apr 3, 2020

I sent you a PR lytex#1. If you accept, this PR here will be updated. See also https://github.com/bnavigator/Slycot/tree/complex-pyf for Travis CI results.

Copy link
Collaborator

@roryyorke roryyorke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two docstring changes requested.

slycot/analysis.py Show resolved Hide resolved
slycot/analysis.py Show resolved Hide resolved
@roryyorke roryyorke merged commit ee1f019 into python-control:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants