Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sg03ad parameter N is not hidden by the wrapper #87

Merged
merged 2 commits into from
Apr 11, 2020

Conversation

bnavigator
Copy link
Collaborator

@bnavigator bnavigator commented Jan 26, 2020

Minor fix of the docstring. Plus some automatic pep8 fixes done by the IDE (separate commit)

@bnavigator bnavigator changed the title sg03ad n docchang sg03ad parameter N is not hidden by the wrapper Jan 26, 2020
@bnavigator
Copy link
Collaborator Author

Travis CI fail: another problem with looking up openblas (#85)

876 -- A library with LAPACK API found.
786 -- LAPACK: 

...

1705 ImportError: /home/travis/miniconda/envs/test-environment/lib/python3.5/site-packages/slycot-0.3.5.11-py3.5-linux-x86_64.egg/slycot/_wrapper.so: undefined symbol: dgebal_
1706 The command "python Slycot/runtests.py --coverage --no-build" exited with 1.

@murrayrm
Copy link
Member

There are also some alternative fixes in the conda-forge feedstock for Slycot.

@bnavigator
Copy link
Collaborator Author

I don't see anything in there that affects the TravisCI fail not finding it's openblas env on the CONDA=0 job.

#85 or #89 are the way to go.

@roryyorke
Copy link
Collaborator

All changes look good.

@roryyorke roryyorke merged commit 3062de5 into python-control:master Apr 11, 2020
@bnavigator bnavigator deleted the sg03ad-N-docchange branch December 31, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants