Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages entry to setup.py metadata #66

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

jakevdp
Copy link
Contributor

@jakevdp jakevdp commented Jun 18, 2019

Without this entry, pip install fails to add the package to the Python path.

Without this entry, pip install fails to add the package to the Python path.
@moorepants
Copy link
Contributor

We're getting a build error on Travis:

$ sh -e /etc/init.d/xvfb start
sh: 0: Can't open /etc/init.d/xvfb
The command "sh -e /etc/init.d/xvfb start" exited with 127.
...
Could not connect to any X display.
The command "cd control; python setup.py test" exited with 1.

I think this is there to allow matplotlib to run. Maybe we can switch to setting the matplotlib to a backend that doesn't require a display?

@moorepants
Copy link
Contributor

This looks like a fix: https://benlimmer.com/2019/01/14/travis-ci-xvfb/

@murrayrm
Copy link
Member

The python-control package implements the new Travis CI format for xenial:

python-control/python-control#298

Should just need to replicate this in .travis.yml.

@roryyorke
Copy link
Collaborator

roryyorke commented Jun 18, 2019

@jakevdp thank you! With this, a pyproject.toml and some CMake tweaks I can get "pip install tarball" to work.
I'm going to add the .travis.yml fix from python-control/python-control#298 to this PR.

@jakevdp
Copy link
Contributor Author

jakevdp commented Jun 18, 2019

Maybe related (I was thinking about doing another PR) I needed to make this tweak to get pip install . to work correctly on the system I was working in:

$ !sed -i "s/from distutils.sysconfig import get_python_lib as pl; print(pl())/import os,numpy; print(os.path.dirname(numpy.__path__[0]))/" Slycot/CMakeLists.txt

This makes certain that the compilation finds the f2py sources even if numpy is not installed in the standard distutils path. I'm not certain whether it would introduce issues on other systems, though.

@jakevdp
Copy link
Contributor Author

jakevdp commented Jun 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants