Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 2.7 install and .travis configuration file issue. #62

Merged
merged 2 commits into from
May 18, 2019

Conversation

jgspiro
Copy link
Contributor

@jgspiro jgspiro commented May 13, 2019

Fix for installing Slycot in a Python 2.7 environment - unupported ConfigParser functionality for python 2.7.

Error was :

ERROR: Complete output from command python setup.py egg_info:
    ERROR: Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-TzgjyK/slycot/setup.py", line 279, in <module>
        setup_package()
      File "/tmp/pip-install-TzgjyK/slycot/setup.py", line 210, in setup_package
        VERSION, gitrevision = get_version_info(src_path)
      File "/tmp/pip-install-TzgjyK/slycot/setup.py", line 149, in get_version_info
        FULLVERSION = setupcfg['metadata'].get('version', 'Unknown')
    AttributeError: ConfigParser instance has no attribute '__getitem__'
    ----------------------------------------

the .travis.yml file contains a wrong python 3.5 and 3.6 configuration.

@jgspiro jgspiro changed the title Fix Python 2.7 install Fix Python 2.7 install and .travis configuration file issue. May 13, 2019
@roryyorke
Copy link
Collaborator

Looks good, thank you. For the record, to trigger this bug setup.cfg must exist and .git must not. To trigger the bug, I first ran "setup.py sdist", unpacked the source distribution, and ran 'setup.py`.

If possible, please try not to include unrelated white-space changes in future PRs -- it adds a little speed-bump to reviewing.

@roryyorke roryyorke merged commit ea4ce7b into python-control:master May 18, 2019
@jgspiro
Copy link
Contributor Author

jgspiro commented May 20, 2019

@roryyorke You are correct about what is required to trigger the install issue. Note that this is the case when installing Slycot from PyPI since the sources are released there.

@jgspiro jgspiro mentioned this pull request May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants