Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slycot to version 0.3.3 #28

Merged
merged 5 commits into from
Jun 30, 2018

Conversation

murrayrm
Copy link
Member

@murrayrm murrayrm commented Jun 29, 2018

This PR updates slycot to version 0.3.3 in setup.py and the meta.yaml files in the conda recipes. It also updates the README file to copy over changes from (now incompatible) PR #22 and sets up a new variable slycot.__version__.

Someone (@repagh? @roryyorke?) should do a quick check on this PR and then we can merge and release v0.3.3.

The changes in v0.3.3 over v0.3.2 are:

@murrayrm
Copy link
Member Author

Note: errors in Travis CI are due to python-control issue #194. Code compiles correctly and all (slycot) unit tests pass.

@repagh
Copy link
Member

repagh commented Jun 29, 2018

Looks good, but should the README be further cleaned up?

  • remove PythonXY stuff? That is python 2.7 only, I don't want to encourage people taking that up, unless the project rekindles and starts using Python 3
  • add Windows to the list for conda?
  • mention that openblas is an option?

@murrayrm murrayrm merged commit a3b8597 into python-control:master Jun 30, 2018
@murrayrm murrayrm deleted the update-version branch June 30, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants