Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test unset BLAS and MKL on conda package for Windows #145

Merged
merged 2 commits into from
Feb 6, 2021

Conversation

bnavigator
Copy link
Collaborator

Hopefully closes actions/toolkit#144

@bnavigator
Copy link
Collaborator Author

Meh: actions/runner#2347

@roryyorke
Copy link
Collaborator

This is probably revealing some arcane low-level bug, but I think it's likely not in Slycot; if it is, it's in build configuration.

Shall we drop the Windows Generic builds altogether? conda by default installs MKL, and I guess most people who don't want that use OpenBLAS.

As I understand, we use conda-forge's recommended build method, and so we always compile and link against the generic libs anyway. The difference comes at runtime, when different BLAS / LAPACK implementations are loaded.

@bnavigator
Copy link
Collaborator Author

Shall we drop the Windows Generic builds altogether? conda by default installs MKL, and I guess most people who don't want that use OpenBLAS.

Look at the job results of this PR. The fails are random. This time in the OpenBLAS builds.

@bnavigator bnavigator changed the title failok for all Windows versions unless BLAS is unset or mkl Only test unset BLAS and MKL on conda package for Windows Feb 3, 2021
@roryyorke
Copy link
Collaborator

Thanks @bnavigator . I'm going to open an issue on this, so if anyone has the stamina to setup a Windows development environment they can investigate.

@roryyorke roryyorke merged commit d4a7049 into python-control:master Feb 6, 2021
@bnavigator bnavigator deleted the windows-failok branch May 3, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow badges return 404
2 participants